Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move highlight_html.js #45372

Merged
merged 9 commits into from
Sep 13, 2019
Merged

Move highlight_html.js #45372

merged 9 commits into from
Sep 13, 2019

Conversation

gospodarsky
Copy link

@gospodarsky gospodarsky commented Sep 11, 2019 •
edited
Loading

Summary

#43439

Move core_plugins/kibana/common/highlight/highlight_html.js to src/plugins/data

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gospodarsky gospodarsky requested a review from a team as a code owner September 11, 2019 12:44
@gospodarsky gospodarsky self-assigned this Sep 11, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

lizozom
lizozom approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gospodarsky gospodarsky merged commit 680d846 into elastic:master Sep 13, 2019
@gospodarsky gospodarsky mentioned this pull request Sep 13, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Sep 13, 2019
Move highlight_html.js (#45372) (#45617)
a120a24 
* Convert getHighlightHtml() to TS

* Convert htmlTags to TS

* Convert highlightTags to TS

* Convert getHighlightRequest() to TS

* Convert index.js to index.ts

* Move tests to TS

* Move highlight to plugins/data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

@streamich streamich Awaiting requested review from streamich

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

@gospodarsky gospodarsky

Labels
Feature:New Platform release_note:enhancement v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gospodarsky @elasticmachine @lizozom